D3D9: Port flush heuristic from D3D11 #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably don't want to flush halfway through some commands like StretchRect, ProcessVertices, LockImage and Clear which have a couple of EmitCs'es... A few of these can probably be changed to be a lot smarter/less shit than the code I wrote like 3 years ago to avoid that too. |
doitsujin
force-pushed
the
d3d9-flush-rework
branch
from
311b477
to
c91d05c
Compare
|
This currently breaks Gothic 3, which wont continue after finishing loading a game. Not sure if Josh's remarks would fix it. |
misyltoad
force-pushed
the
d3d9-flush-rework
branch
from
c91d05c
to
f8343ed
Compare
doitsujin
force-pushed
the
d3d9-flush-rework
branch
from
f8343ed
to
cc052a1
Compare
|
Gothic should be fixed. |
|
yep works now 🍻 |
|
Looks fine but I still want to merge some of these EmitCses at some point.., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs testing.
The flush heuristic itself already works well for D3D11 in practice, with major benefits being that: